`Adaptive learning`: Fix learner profile settings #11324

ahmetsenturk · 2025-08-22T11:08:13Z

Checklist

General

I tested all changes and their related features with all corresponding user types on a test server.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
I strictly followed the principle of data economy for all client-server REST calls.
I strictly followed the client coding and design guidelines.
Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
I documented the TypeScript code using JSDoc style.
I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Learner profile interface had some small flaws regarding UI/UX, and was raising an internal service error due to a duplicate object generation trial on CourseLearnerProfileResource

Description

I fixed the problems on the client side and also the CourseLearnerProfileResource

Steps for Testing

Prerequisites:

1 Student

Log in to Artemis
Navigate to Settings, and Learner Profile
Observe that titles are aligned, and segmented buttons are of the same width
Observe that you don't get an Internal Server Error when the page opens

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Test Coverage

Screenshots

Summary by CodeRabbit

Style
- Improved learner profile feedback layout; toggles consistently align to the bottom of columns.
- Segmented toggle buttons are equal-width, centered, support two-line labels with ellipsis, and show tooltips for full labels.
Bug Fixes
- Prevents creation of duplicate learner profiles for the same user and course.
- Updated validation messages for feedback learner profile to require values between 1 and 3 (EN/DE).

…back-preferences

HawKhiem

Tested on TS1 as student, works as expected. However when I tested with an instructor, I got the Internal Server Error. With student, editor and tutor works fine

github-actions · 2025-09-04T11:09:56Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	205 ran	199 passed	3 skipped	3 failed	1h 8m 29s 849ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 4s 90ms
e2e/exam/ExamResults.spec.ts
ts.Exam Results › Check exam exercise results › Check exam results for modeling exercise › Check exam modeling exercise results	❌ failure	3m 26s 802ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	2m 19s 860ms

tobikli

lgtm

LeZhen1105

code looks good

github-actions · 2025-09-17T11:45:04Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	205 ran	201 passed	3 skipped	1 failed	1h 5m 686ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts
ts.Quiz Exercise Participation › DnD Quiz participation › Student can participate in DnD Quiz	❌ failure	2m 3s 455ms

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0046adc and bc9aa84.

📒 Files selected for processing (1)

src/main/java/de/tum/cit/aet/artemis/atlas/repository/CourseLearnerProfileRepository.java (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/main/java/**/*.java

⚙️ CodeRabbit configuration file

naming:CamelCase; principles:{single_responsibility,small_methods,no_duplication}; db:{perf_queries,datetime_not_timestamp}; rest:{stateless,singleton,delegate_logic,http_only,minimal_dtos}; dtos:{java_records,no_entities,min_data,single_resp}; di:constructor_injection; kiss:simple_code; file_handling:os_indep_paths; practices:{least_access,avoid_transactions,code_reuse,static_member_ref,prefer_primitives}; sql:{param_annotation,uppercase,avoid_subqueries};java:avoid_star_imports

Files:

src/main/java/de/tum/cit/aet/artemis/atlas/repository/CourseLearnerProfileRepository.java

🧠 Learnings (3)

📚 Learning: 2025-05-24T16:06:41.454Z

Learnt from: tobias-lippert
PR: ls1intum/Artemis#10812
File: src/main/java/de/tum/cit/aet/artemis/atlas/repository/CompetencyRepository.java:70-88
Timestamp: 2025-05-24T16:06:41.454Z
Learning: In CompetencyRepository JPQL queries that join from LearningPath to course competencies, DISTINCT is not necessary because a learning path belongs to exactly one course, preventing duplicate competencies in the result set.

Applied to files:

src/main/java/de/tum/cit/aet/artemis/atlas/repository/CourseLearnerProfileRepository.java

📚 Learning: 2025-09-05T15:13:32.171Z

Learnt from: MoritzSpengler
PR: ls1intum/Artemis#11345
File: src/main/java/de/tum/cit/aet/artemis/quiz/repository/QuizTrainingLeaderboardRepository.java:22-23
Timestamp: 2025-09-05T15:13:32.171Z
Learning: The derived query method name `findByLeagueAndCourseIdOrderByScoreDescUserAscId` in QuizTrainingLeaderboardRepository correctly references the `user` entity field directly in the OrderBy clause, not requiring `userId`. Spring Data JPA supports sorting by entity references directly in derived query method names.

Applied to files:

src/main/java/de/tum/cit/aet/artemis/atlas/repository/CourseLearnerProfileRepository.java

📚 Learning: 2024-10-08T15:35:42.972Z

Learnt from: Strohgelaender
PR: ls1intum/Artemis#8574
File: src/main/java/de/tum/in/www1/artemis/service/tutorialgroups/TutorialGroupService.java:0-0
Timestamp: 2024-10-08T15:35:42.972Z
Learning: The `tryToFindMatchingUsers` method in `TutorialGroupService.java` has been updated to skip registrations without a student, enhancing the method's robustness. This change was implemented in commit `bef30f9751de0913143e8cb28cc0088264052261`.

Applied to files:

src/main/java/de/tum/cit/aet/artemis/atlas/repository/CourseLearnerProfileRepository.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

GitHub Check: Codacy Static Code Analysis
GitHub Check: Analyse
GitHub Check: Build and Push Docker Image / Build linux/amd64 Docker Image for ls1intum/artemis
GitHub Check: Build and Push Docker Image / Build linux/arm64 Docker Image for ls1intum/artemis
GitHub Check: Build .war artifact
GitHub Check: client-tests-selected
GitHub Check: server-tests
GitHub Check: client-tests
GitHub Check: server-style
GitHub Check: bean-instantiation-check

🔇 Additional comments (1)

src/main/java/de/tum/cit/aet/artemis/atlas/repository/CourseLearnerProfileRepository.java (1)

49-54: Good addition: fetch-join prevents LIE/N+1 on Course.

Adding LEFT JOIN FETCH clp.course here is consistent with the other methods in this repository and avoids lazy-init issues when serializing/using the associated Course.

Please confirm CourseLearnerProfile.course is a ManyToOne (or otherwise non-collection) association to ensure no row explosion with the fetch join.

src/main/java/de/tum/cit/aet/artemis/atlas/repository/CourseLearnerProfileRepository.java

github-actions · 2025-09-17T14:03:15Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	205 ran	199 passed	3 skipped	3 failed	1h 18m 20s 490ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 3s 906ms
e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts
ts.Quiz Exercise Participation › DnD Quiz participation › Student can participate in DnD Quiz	❌ failure	2m 6s 319ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	2m 33s 68ms

This reverts commit bc9aa84.

github-actions · 2025-09-18T08:57:32Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ✅	Skipped	Failed	Time ⏱
End-to-End (E2E) Test Report	1 ran	1 passed	0 skipped	0 failed	1s 598ms

Test	Result	Time ⏱
No test annotations available

github-actions · 2025-09-18T09:40:04Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	205 ran	200 passed	3 skipped	2 failed	1h 15m 7s 715ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 3s 617ms
e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts
ts.Quiz Exercise Participation › DnD Quiz participation › Student can participate in DnD Quiz	❌ failure	2m 5s 572ms

github-actions · 2025-09-18T19:33:58Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ✅	Skipped	Failed	Time ⏱
End-to-End (E2E) Test Report	1 ran	1 passed	0 skipped	0 failed	1s 619ms

Test	Result	Time ⏱
No test annotations available

tobias-lippert

Reapprove code

ahmetsenturk and others added 30 commits July 3, 2025 19:11

add previous submission to athena feedback request dto

5fdb3ad

remove debugging prints

9b02073

add the skeleton modal for preference selection

bdb02e2

add the navigation logic to the modal

2a2d7e4

add a persistent flag for onboarding logic

e7576e3

update folder structure

0eced8f

emit results from the modal

c260a64

Merge branch 'develop' into feature/adaptive-learning/onboarding-feed…

c890ac2

…back-preferences

Merge branch 'develop' into feature/athena/incorporate-prev-submission

764661d

fix last merge conflict issues

bba14b4

Merge branch 'develop' into feature/athena/incorporate-prev-submission

51cfeee

Merge branch 'develop' into feature/adaptive-learning/onboarding-feed…

29ade1e

…back-preferences

add translations

bfbc238

update the feedback dimensions

7a3190c

update feedback profile options

4f74f2e

update segmented-toggle focus color

f4515fd

fix learner profile fetching

d4d863f

update test cases

84b0c45

Merge branch 'develop' into feature/athena/incorporate-prev-submission

b018089

Merge branch 'develop' into feature/adaptive-learning/onboarding-feed…

8ff0484

…back-preferences

update get to get or create

192e78f

Merge branch 'develop' into feature/adaptive-learning/onboarding-feed…

3e134a8

…back-preferences

add neutral option to feedback preferences

b8a9973

optimize db calls

7dcf297

Merge branch 'develop' into feature/adaptive-learning/onboarding-feed…

f46c4f5

…back-preferences

Merge branch 'develop' into feature/athena/incorporate-prev-submission

705fc98

fix client tests

3e690be

address Konstantins review

754cc4d

fix client tests

c3bd5ce

Merge branch 'develop' into feature/adaptive-learning/onboarding-feed…

7b04fa6

…back-preferences

helios-aet bot temporarily deployed to artemis-test1.artemis.cit.tum.de September 4, 2025 10:35 Inactive

HawKhiem previously approved these changes Sep 4, 2025

View reviewed changes

helios-aet bot temporarily deployed to artemis-test5.artemis.cit.tum.de September 10, 2025 09:27 Inactive

tobikli previously approved these changes Sep 11, 2025

View reviewed changes

helios-aet bot temporarily deployed to artemis-test6.artemis.cit.tum.de September 12, 2025 09:06 Inactive

maximiliansoelch had a problem deploying to https://artemis-test1.artemis.cit.tum.de September 12, 2025 09:25 — with GitHub Actions Failure

maximiliansoelch temporarily deployed to artemis-test1.artemis.cit.tum.de September 12, 2025 09:50 — with GitHub Actions Inactive

LeZhen1105 previously approved these changes Sep 12, 2025

View reviewed changes

Merge branch 'develop' into bugfix/learner-profile-settings

1c194a7

fix hibernate no session with left join fetch

bc9aa84

ahmetsenturk dismissed stale reviews from ekayandan, LeZhen1105, jfr2102, tobias-lippert, tobikli, HawKhiem, and coderabbitai[bot] via bc9aa84 September 17, 2025 13:09

coderabbitai bot requested changes Sep 17, 2025

View reviewed changes

src/main/java/de/tum/cit/aet/artemis/atlas/repository/CourseLearnerProfileRepository.java Show resolved Hide resolved

Revert "fix hibernate no session with left join fetch"

53c1553

This reverts commit bc9aa84.

coderabbitai bot previously approved these changes Sep 18, 2025

View reviewed changes

re-add left-join

1ccc18b

ahmetsenturk dismissed coderabbitai[bot]’s stale review via 1ccc18b September 18, 2025 08:47

Merge branch 'develop' into bugfix/learner-profile-settings

63ae1a1

tobias-lippert approved these changes Sep 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`Adaptive learning`: Fix learner profile settings #11324

`Adaptive learning`: Fix learner profile settings #11324

ahmetsenturk commented Aug 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

HawKhiem left a comment

Uh oh!

github-actions bot commented Sep 4, 2025

Uh oh!

tobikli left a comment

Uh oh!

LeZhen1105 left a comment

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

tobias-lippert left a comment

Uh oh!

Uh oh!

Adaptive learning: Fix learner profile settings #11324

Are you sure you want to change the base?

Adaptive learning: Fix learner profile settings #11324

Conversation

ahmetsenturk commented Aug 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Client

Motivation and Context

Description

Steps for Testing

Testserver States

Review Progress

Test Coverage

Screenshots

Summary by CodeRabbit

Uh oh!

HawKhiem left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 4, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

tobikli left a comment

Choose a reason for hiding this comment

Uh oh!

LeZhen1105 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 17, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Sep 17, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

github-actions bot commented Sep 18, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

github-actions bot commented Sep 18, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

github-actions bot commented Sep 18, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

tobias-lippert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

`Adaptive learning`: Fix learner profile settings #11324

`Adaptive learning`: Fix learner profile settings #11324

ahmetsenturk commented Aug 22, 2025 •

edited by coderabbitai bot

Loading